research: test nested approve authorization for upto - #240
Merged
Conversation
|
@dedukpe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
Summary
Resolves #62 by experimentally testing whether a single Soroban authorization entry can cover an
authorizecall containing a nested SEP-41token.approvesub-invocation.What Was Tested
@x402/stellarvalidateAuthEntriesbehavior.Findings
The spike documents whether Soroban technically permits the construction separately from whether the current x402 Stellar facilitator/ecosystem considers the authorization acceptable.
ADR-002 §6.2 has been updated with the resulting evidence and recommendation.
Scope
This is an isolated research spike.
No production upto implementation or production contract authorization behavior was changed.
Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceEvidence
The PR includes the reproducible experiment, authorization-tree analysis, budget comparison, and
validateAuthEntriesfindings.